Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rake (and rake-compiler) to suppress the warning. #1099

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Jan 2, 2020

This fixes #1095 .

To suppress the warning:

/home/travis/.rvm/gems/ruby-head/gems/rake-10.4.2/lib/rake/application.rb:381: warning: deprecated Object#=~ is called on Proc; it always returns nil

in the process of bundle exec rake compile.

First I tried to update Gemfile like this.

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.2")
  gem 'rake', '~> 13.0.1'
else
  gem 'rake', '< 13'
end

But rubocop printed the error message. So, I modified the file as this PR.

Gemfile:8:3: C: Bundler/DuplicatedGem: Gem rake requirements already given on line 6 of the Gemfile.
  gem 'rake', '< 13'
  ^^^^^^^^^^^^^^^^^^

It was succeeded on my forked repository's Travis.
https://travis-ci.org/junaruga/mysql2/builds/631909854

To suppress the warning:
/home/travis/.rvm/gems/ruby-head/gems/rake-10.4.2/lib/rake/application.rb:381: warning: deprecated Object#=~ is called on Proc; it always returns nil
in the process of "bundle exec rake compile".
@sodabrew sodabrew merged commit 475c450 into brianmario:master Jan 2, 2020
@sodabrew
Copy link
Collaborator

sodabrew commented Jan 2, 2020

Good update, thank you!

@sodabrew sodabrew added this to the 0.5.4 milestone Jan 2, 2020
@junaruga junaruga deleted the hotfix/warning-rake branch January 2, 2020 18:17
snehaso pushed a commit to fac/mysql2 that referenced this pull request Jan 21, 2020
…1099)

To suppress the warning:
/home/travis/.rvm/gems/ruby-head/gems/rake-10.4.2/lib/rake/application.rb:381: warning: deprecated Object#=~ is called on Proc; it always returns nil
in the process of "bundle exec rake compile".
snehaso pushed a commit to fac/mysql2 that referenced this pull request Jan 21, 2020
…1099)

To suppress the warning:
/home/travis/.rvm/gems/ruby-head/gems/rake-10.4.2/lib/rake/application.rb:381: warning: deprecated Object#=~ is called on Proc; it always returns nil
in the process of "bundle exec rake compile".
snehaso pushed a commit to fac/mysql2 that referenced this pull request Jan 22, 2020
…1099)

To suppress the warning:
/home/travis/.rvm/gems/ruby-head/gems/rake-10.4.2/lib/rake/application.rb:381: warning: deprecated Object#=~ is called on Proc; it always returns nil
in the process of "bundle exec rake compile".
snehaso pushed a commit to fac/mysql2 that referenced this pull request Jan 22, 2020
…1099)

To suppress the warning:
/home/travis/.rvm/gems/ruby-head/gems/rake-10.4.2/lib/rake/application.rb:381: warning: deprecated Object#=~ is called on Proc; it always returns nil
in the process of "bundle exec rake compile".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client.c: warnings when building with Ruby 2.7
2 participants