Fix MySQL Encoding Tables #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and prefix it with MYSQL2_ to match existing definitions.
and fix a bug mapping them to "" instead of NULL.
MySQL 8.0 Community APT packages are only available from 16.04, so we need to use "dist: xenial" on Travis CI.
|
I pushed another unrelated CI fix to use Xenial distribution for the |
* gem update --system tries to use rubygems-update 3.0 which requires ruby >= 2.3.0, so use ~> 2.7 * latest bundler 2.x also requires ruby >= 2.3.0, so use ~> 1.17
|
CI errors are unrelated and already fixed by #1040. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the generator script, missing MySQL encoding mappings caused empty strings instead of NULL mappings to be generated.
This PR fixes the mapping error and generates a WARNING to STDERR for missing mappings.
It also adds the two missing mappings that caused the problem and regenerates the encoding list based on the latest MySQL 8.0.16 community server on Ubuntu Xenial.
To avoid CI failures an update to the expired GPG key in
support/5072E1F5.ascis also included and was copied from https://dev.mysql.com/doc/refman/8.0/en/checking-gpg-signature.html.