Skip to content

Commit

Permalink
Merge pull request #1176 from junaruga/wip/refactor-ci
Browse files Browse the repository at this point in the history
Refactor CI yaml files
  • Loading branch information
sodabrew authored Apr 1, 2021
2 parents b439a89 + ec1dac4 commit 346b4a4
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 19 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
# Run all the tests on the new environment as much as possible.
# https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners
runs-on: ${{ matrix.os }}
continue-on-error: ${{ matrix.allow-failure }}
continue-on-error: ${{ matrix.allow-failure || false }}
strategy:
matrix:
os:
Expand All @@ -26,16 +26,15 @@ jobs:
- 2.2
- 2.1
db: ['']
allow-failure: [false]
include:
# Allow failure due to Mysql2::Error: Unknown system variable 'session_track_system_variables'.
- {os: ubuntu-16.04, ruby: 2.4, db: mariadb10.0, allow-failure: true}
# Comment out due to ci/setup.sh stucking.
# - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1, allow-failure: false}
# Allow failure due to the issue #1165.
- {os: ubuntu-20.04, ruby: 2.4, db: mariadb10.3, allow-failure: true}
- {os: ubuntu-18.04, ruby: 2.4, db: mysql57, allow-failure: false}
# - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1}
# `service mysql restart` fails.
- {os: ubuntu-20.04, ruby: 2.4, db: mariadb10.3, allow-failure: true}
- {os: ubuntu-18.04, ruby: 2.4, db: mysql57}
# Allow failure due to the issue #1165.
- {os: ubuntu-20.04, ruby: 2.4, db: mysql80, allow-failure: true}
- {os: ubuntu-18.04, ruby: 'head', db: '', allow-failure: true}
# db: A DB's brew package name in macOS case.
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ on: [push, pull_request]
jobs:
build:
name: >-
${{ matrix.distro }} ${{ matrix.image }}
${{ matrix.distro }} ${{ matrix.image }} ${{ matrix.name_extra || '' }}
runs-on: ubuntu-20.04 # focal
continue-on-error: ${{ matrix.allow-failure }}
continue-on-error: ${{ matrix.allow-failure || false }}
strategy:
matrix:
include:
- {distro: centos, image: 'centos:7', allow-failure: false}
# CentOS 7 system Ruby is the fixed version 2.0.0.
- {distro: centos, image: 'centos:7', name_extra: 'ruby 2.0.0'}
# Fedora latest stable version
# Allow failure due to the following test failures.
# https://github.com/brianmario/mysql2/issues/965
Expand Down
10 changes: 0 additions & 10 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
sudo: required
dist: trusty
language: ruby
bundler_args: --without development
Expand All @@ -9,17 +8,8 @@ before_install:
- gem update bundler
- gem --version
- bash ci/setup.sh
addons:
hosts:
- mysql2gem.example.com
apt:
packages:
- mysql-server-5.6
- mysql-client-core-5.6
- mysql-client-5.6
matrix:
include:
- rvm: 2.0.0
- rvm: 2.4
env: DB=mariadb10.0
addons:
Expand Down

1 comment on commit 346b4a4

@junaruga
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sodabrew The 2 macos cases on GitHub Actions failed because the GitHub Actions cases did not start. As a result, we see the build status budge shows "failing". It might be better to rerun the CI again manually.
https://github.com/brianmario/mysql2/runs/2245938703?check_suite_focus=true

Please sign in to comment.