Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window-name adapter nuke function #108

Open
BirkAndMe opened this issue May 22, 2012 · 1 comment · Fixed by #130
Open

window-name adapter nuke function #108

BirkAndMe opened this issue May 22, 2012 · 1 comment · Fixed by #130

Comments

@BirkAndMe
Copy link

The window-name adapters nuke function isn't working.
Instead of setting the window.top.name to an empty object it reuses the current object.

I've changed this in my own fork: https://github.com/BirkAndMe/lawnchair/blob/master/src/adapters/window-name.js.

But I'm fairly new at github so I don't know the procedure for suggesting and discussing fixes...
@abdielou
Copy link

same here

cscott added a commit to cscott/lawnchair that referenced this issue Oct 17, 2012
@cscott
Fix 'independent data stores' failure in memory and window-name adapt…
01cf775 
…ers.

Also fixes issue brianleroux#108 with the nuke() method, while we're at it.

In addition, a few minor changes to try to make memory and window-name more
nearly identical, although a number of unnecessary whitespace diffs remain.
@cscott cscott mentioned this issue Oct 17, 2012
Merged
brianleroux added a commit that referenced this issue Oct 17, 2012
@brianleroux
Merge pull request #130 from cscott/for-upstream-20121017
94cc0c6 
Firefox compatibility, IndexedDB fixes; batch remove fixes; issue #108.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Firefox compatibility, IndexedDB fixes; batch remove fixes; issue #108. cscott/lawnchair
2 participants
@BirkAndMe @abdielou