Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[griddb] GridDB binding #1258

Merged
merged 15 commits into from
Jun 4, 2019
Merged

[griddb] GridDB binding #1258

merged 15 commits into from
Jun 4, 2019

Conversation

knonomura
Copy link
Contributor

I made a new pull request for adding GridDB binding to YCSB project.

GridDB (https://github.com/griddb/griddb_nosql) is a highly scalable NoSQL database best suited for IoT and Big Data.

Let me know if this is OK with you.

Thanks.

Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance we could add tests?

griddb/README.md Show resolved Hide resolved
griddb/src/main/java/com/yahoo/ycsb/db/GridDBClient.java Outdated Show resolved Hide resolved
griddb/src/main/java/com/yahoo/ycsb/db/GridDBClient.java Outdated Show resolved Hide resolved
griddb/src/main/java/com/yahoo/ycsb/db/GridDBClient.java Outdated Show resolved Hide resolved
griddb/src/main/java/com/yahoo/ycsb/db/package-info.java Outdated Show resolved Hide resolved
@knonomura
Copy link
Contributor Author

Thank you for your time to review my pull request.
I will reflect your comment.

@knonomura
Copy link
Contributor Author

I reflected all your comments.
Could you please check them ?

And I added a simple test code.
I have a caution.
Please use the following values for GridDB server or change them.
(GridDBClientTest.java)
private final static String NOTIFICATION_PORT = "31999";//default is 31999
private final static String NOTIFICATION_ADDR = "239.0.0.1";//default is 239.0.0.1
private final static String CLUSTER_NAME = "ycsbcluster";//Fill your cluster name
private final static String USER_NAME = "admin";//Fill your user name
private final static String PASS = "admin";//Fill your password

Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of quick changes and this should be good to merge.

looks like it needs a rebase, if you have a chance.

bin/ycsb Outdated
@@ -76,6 +76,7 @@ DATABASES = {
"geode" : "com.yahoo.ycsb.db.GeodeClient",
"googlebigtable" : "com.yahoo.ycsb.db.GoogleBigtableClient",
"googledatastore" : "com.yahoo.ycsb.db.GoogleDatastoreClient",
"griddb" : "com.yahoo.ycsb.db.GridDBClient",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should point to com.yahoo.ycsb.db.griddb.GridDBClient now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed package name for GridDB by 81cf64a .


LOGGER.info("notificationAddress=" + notificationAddress + " notificationPort=" + notificationPort +
" notificationMember=" + notificationMember);
LOGGER.info("clusterName=" + clusterName + " userName=" + userName + " password=" + password);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally speaking, one should not log passwords.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cut password log by 86f7c71 .

@knonomura
Copy link
Contributor Author

I reflected your comments and run a rebase.

Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the Travis failures. It looks like you're missing test scope dependencies.

@knonomura
Copy link
Contributor Author

I'm sorry, but I forgot to update pom.xml.
I added dependency for test in pom.xml.

Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the remaining test failure is a known problem with oracle jdk8 on travis that's fixed on current master branch.

@busbey busbey merged commit c695486 into brianfrankcooper:master Jun 4, 2019
@busbey
Copy link
Collaborator

busbey commented Jun 4, 2019

thanks so much for all the work here @knonomura ! I'll send you a note when there's a release candidate with this binding ready for testing.

@knonomura
Copy link
Contributor Author

Thank you very much for your review.

@busbey busbey mentioned this pull request Jun 4, 2019
@busbey busbey mentioned this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants