Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override and implement abstract method inherited from HttpClientRequest #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.5.3'
classpath 'com.android.tools.build:gradle:4.1.1'
}
}
rootProject.allprojects {
Expand All @@ -18,7 +18,7 @@ rootProject.allprojects {
}
apply plugin: 'com.android.library'
android {
compileSdkVersion 29
compileSdkVersion 30

defaultConfig {
minSdkVersion 16
Expand Down
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip
5 changes: 5 additions & 0 deletions lib/src/http_client_request.dart
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,9 @@ class StethoHttpClientRequest implements HttpClientRequest {
_streamController.add(obj.toString().codeUnits);
}
}

@override
void abort([Object exception, StackTrace stackTrace]) {
request.addError(exception, stackTrace);
}
}