Remove test globals #3264
Merged
Remove test globals #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying node-postgres with
|
| Latest commit: |
1b4e9b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5915b92c.node-postgres.pages.dev |
| Branch Preview URL: | https://bmc-remove-test-globals.node-postgres.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the older (very old) code in the test files was relying on global variables defined in other files. A bad decision from many years ago I have been meaning to rectify. Removed the global
assertfunction (it is still monkey patched in./test-helperbut that's not as bad) and also removed the globaltestfunction, global instances ofClientand the few places globalMemoryStreamwas used. Now everything is imported/required within the file(s) its used.