Add support for ?sslmode connection string param #2345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1949
If you're using connection strings, you can't use the
PGSSLMODE=no-verify
envvar because that's only used whenconfig.ssl
is not set. I use?ssl=true&sslmode=no-verify&sslrootcert=/app/data/amazon-rds-ca-cert.pem
which does setconfig.ssl
, so we need to also support parsing sslmode from the connection string. I've copied the logic (roughly) from:node-postgres/packages/pg/lib/connection-parameters.js
Lines 21 to 32 in 8291b23
I didn't see a CONTRIBUTING file, so I've taken a guess at the steps to make a good PR: