Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node V6 Incompatibility? #1029

Closed
KZRepository opened this issue May 24, 2016 · 12 comments
Closed

Node V6 Incompatibility? #1029

KZRepository opened this issue May 24, 2016 · 12 comments

Comments

@KZRepository
Copy link

KZRepository commented May 24, 2016

I tried building our environment with Node V6.2. We had been using Node V5.7 but since have tested with Node V5.9.1. The app has been developed under Windows 10 and deployed under Ubuntu 15.10 moving to 16.04 LTS.

Under Node V6 we hit 3 problems:

  1. Postgres 9.4 and 9.5.3 returned password authentication failure
  2. PM2 1.0.2 would not return after starting a process
  3. When trying to debug under Webstorm 16.1.2 on Windows, the it failed with a "ReferenceError: v8debug is not defined".

All the problems disappeared when reverting to Node v5.9.1

The Webstorm problem is still outstanding with a workaround adding --expose-debug-as=v8debug to "Node parameters" buried on their issues database.

PM2 has a fix in 1.1.3 (not in Ubuntu package repository at this time) labeled "node v6 compat" that consists of removing a call to hasOwnProperty in a wrapper around a cloning function.

Is this a known node-postgres to Node v6 compatibility issue?

@brianc
Copy link
Owner

brianc commented May 24, 2016

Sorry for the issue @stretchKids - can you provide a code sample that works
on node v5 but does not work on node v6? This is high on my list to look
at.

On Monday, May 23, 2016, Vitaly Tomilov [email protected] wrote:

Please research before opening issues. This has been duplicated so many
times by now.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1029 (comment)

@apkoponen
Copy link

I had a similar issue when upgrading from node 5.x to 6.x and was able to fix it just by deleting node_modules folder, running npm install and redeploying the app.

@BornaP
Copy link

BornaP commented May 25, 2016

@apkoponen : In short you have just updated to newer release where bug has been solved :)

I can confirm that I've experienced the same issue before pulling 6fddc56 that resolves it.

@apkoponen
Copy link

Yup.

@LinusU
Copy link
Contributor

LinusU commented Jun 9, 2016

I hade this problem as well, but it was solved by updating to version 5.0.0.

Postgres 9.4 and 9.5.3 returned password authentication failure

@jtiscione
Copy link

I have this "v8debug is not defined" problem with 6.2.0, but reinstalling the node modules didn't help.

@brianc
Copy link
Owner

brianc commented Jun 15, 2016

I have installed node-postgres on node v6 and v5 a whole bunch - never had any issues. I think it's something w/ your environment. Have you tried deleting node_modules?

@jtiscione
Copy link

I figured it out- the correct node option to use (on node 6.2.0) is:
--expose-debug-as=v8debug

@brianc
Copy link
Owner

brianc commented Jun 16, 2016

Weird - I don't have to do that. I just have 6.2 and i do npm i pg and it
"just works" - are you doing something fancy w/ pg that would require
exposing dbug?

On Wed, Jun 15, 2016 at 10:38 PM, Jason Tiscione [email protected]
wrote:

I figured it out- the correct node option to use (on node 6.2.0) is:
--expose-debug-as=v8debug


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1029 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADDoXCQlm2R4DoyT7atlNvJyRDGCdYRks5qMMUrgaJpZM4Ik_W4
.

@jtiscione
Copy link

Whoops- I didn't see the part of the original post where he mentions his Webstorm problem being fixed by "--expose-debug-as=v8debug". Since I'm also using Webstorm I figure it must be a bug on their end.
(The problems with Postgres and PM2 look like a separate issue.)

@jbcpollak
Copy link

jbcpollak commented Jun 22, 2016

Just randomly came across this bug looking for something else. Just to clarify - the v8debug issue is related to WebStorm and has nothing to do with pg. The next patch release of WebStorm will fix that problem.

We are using pg (not directly - through loopback) with Node 6.2.1 and have no issues (with pg)

@brianc
Copy link
Owner

brianc commented Jun 22, 2016

Ah thanks for the update from both @jtiscione and @jbcpollak! Really appreciate y'all diving in on things like this that are slightly outside of the wheelhouse of the lib in general but still impact the community!

@brianc brianc closed this as completed Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants