This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
Remove support for deprecated pg.js package #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: pg.js is long dead and no longer supported. Use [pg](https://www.npmjs.com/package/pg) instead.
|
awesome! Yeah a PR for that would be sweet. I'll merge this right now. This lib needs a bit of modernization/updating love. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg.js is long dead and no longer supported, and screwing around with require code paths causes problems with some debugging and code analysis tools.
Therefore, I think it would make sense to remove this support.
I've tested this with Node 6, 8 and 10, as well as PostgreSQL 9.6, 10 and 11, and the test all pass.
P.S.: I've put together a small docker-compose script to test all the aforementioned Node.js and PostgreSQL combinations locally, I can send a PR for that too, if you're interested.