Various systemd-related improvements #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2016
Closed
|
Just added a further commit to create a systemd-tmpfiles entry after finding my server did not survive a reboot. At this point, I'm thinking the systemd cookbook would be a nice idea but I'll see what you think of all this first. |
|
I usually like to avoid having dependencies on other cookbooks simply because it always seems to eventually cause some sort of headache. However I currently am not steeped to deeply in the systemd world and haven't even looked at that cookbook. It may be a good idea to use it. |
|
What's the status of this one? Are you planning to merge this Pull Request into the official repo soon? What blocks it? cc @KieranHayes |
|
@chewi can you rebase this to solve the conflicts? |
Unfortunately it's not so great for detecting other init systems. This should improve service handling on Debian 8.
The existing script calls redis-shutdown against /etc/redis.conf. It could be fixed to use the correct server instance but the script only supports TCP and not UNIX sockets. There is no point in using redis-shutdown anyway as sending the TERM signal does the same job. This is what systemd does by default. This changes the stop from being synchronous to asynchronous but that doesn't matter because systemd is running redis-server in the foreground. If the shutdown operation takes too long, the server will be killed after TimeoutStopSec either way. There is also the added benefit that if the server has crashed, a failed call to redis-shutdown won't prevent the server from being started again.
A shared file was previously created in the configure recipe. This makes things consistent with the other init systems and ensures that systemd users can use the LWRP alone. Per-instance files are necessary because the shared file had both hardcoded and global default values. The path has changed from /usr/lib/systemd to /lib/systemd to support Debian 8, which doesn't have a merged /usr.
systemctl automatically performs a reload when enabling a service so it is sufficient to enable it in the usual way via action :enable. See man systemctl.
Otherwise redis-server will probably not survive a reboot on systems with /run mounted on tmpfs.
|
Done. |
|
Thanks! |
shortdudey123
added a commit
that referenced
this pull request
May 10, 2017
- Update 'bind' config comments ([#293](#293)) - Add disable_os_default recipe ([#224](#224)) - Use the config's ulimits if set and is > max_clients ([#234](#234)) - Add Travis config ([#299](#299)) - Fix test failures (FoodCritic and Rubocop) ([#298](#298)) - Fix TravisCI builds ([#300](#300)) - Add repl-backlog-size, repl-backlog-ttl, and aof-load-truncated options ([#278](#278)) - Add sentinel_bind to bind sentinel to different IPs ([#306](#306)) - Cleanup deprecation warnings ([#301](#301)) - Fix version detection with epoch version numbers from deb/ubuntu ([#294](#294)) - Restrict VM redis config to <= 2.4 ([#322](#322)) - Rename_commands should be checked for nil before empty ([#311](#311)) - Fixup foodcritic, rubocop, and kitchen testing ([#324](#324)) - Note: this drops support for Chef < 11 - Add min-slaves redis options ([#313](#313)) - Allow /etc/init start after sigterm from system or user ([#310](#310)) - Check user existence with Etc, not ohai node attributes ([#303](#303)) - Various systemd-related improvements ([#302](#302)) - Update serverspec testing with correct OS's for systemd ([#329](#329)) - Add kitchen-dokken testing to Travis ([#330](#330)) - Add fedora-25 to kitchen testing and clean up kitchen config ([#331](#331)) - Fix systemd paths for sentinel service ([#332](#332)) - Add redis-package and sentinel to Travis kitchen verify ([#334](#334)) - Add breadcrumb-file creation condition as attribute ([#268](#268)) - Fix cluster options in README ([#333](#333)) - Fix systemd loader to use descriptors instead of max_clients+32 ([#338](#338)) - Add SELinux support ([#305](#305)) - Make source of redis.conf template configurable ([#341](#341)) - Support sentinel notification-script and client-reconfig-script ([#342](#342))
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Debian/Ubuntu, fixes shutdowns with UNIX sockets, deals with multiple instances, and more.
It fixes #271 and #283. It supersedes #274.