Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemd template uses redis['default_settings']['maxclients'] #316

Closed
altvnk opened this issue Feb 7, 2017 · 4 comments
Closed

Systemd template uses redis['default_settings']['maxclients'] #316

altvnk opened this issue Feb 7, 2017 · 4 comments
Milestone

Comments

@altvnk
Copy link

altvnk commented Feb 7, 2017

Systemd template uses redis['default_settings']['maxclients'] in [configure.rb] recipe (https://github.com/brianbianco/redisio/blob/master/recipes/configure.rb#L45)
This causes that this value cannot be overridden with redisio['servers']['maxclients' and systemd service always receives default file limit 10000. So redis server refuses settings in maxclients key and reduces it to maximum possible:

You requested maxclients of 100000 requiring at least 100032 max file descriptors.
Current maximum open files is 10032. maxclients has been reduced to 10000 to compensate for low ulimit

Resulting piece of systemd unit file:

[Service]
ExecStart=/usr/bin/redis-server /etc/redis/%i.conf --daemonize no
ExecStop=/usr/bin/redis-shutdown
User=redis
Group=redis
LimitNOFILE=10032

I suggest changing this to current['maxclients'] which is respects user settings.

@shortdudey123
Copy link
Contributor

@brownc feel free to make a PR and i will take a look at it, thanks!!

@shortdudey123
Copy link
Contributor

actually it looks like #302 covers this

@shortdudey123
Copy link
Contributor

Solved by #302

@shortdudey123 shortdudey123 added this to the 2.6.0 milestone Apr 27, 2017
@lock
Copy link

lock bot commented Nov 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants