Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Zstandard & Snappy Readers #105

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Conversation

jshlbrd
Copy link
Collaborator

@jshlbrd jshlbrd commented Apr 22, 2023

Description

Motivation and Context

zstd and Snappy compression was added in #93, but decompression (reading) wasn't. Ideally we want to maintain parity in our support for readers and writers so that users can use compressed files without needing external software.

How Has This Been Tested?

Added unit tests and tested locally using the file sink.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jshlbrd jshlbrd marked this pull request as ready for review April 24, 2023 15:26
@jshlbrd jshlbrd requested a review from a team as a code owner April 24, 2023 15:26
@jshlbrd jshlbrd changed the title feat: Add Zstandard & Readers feat: Add Zstandard & Snappy Readers Apr 24, 2023
@jshlbrd jshlbrd merged commit 8c69907 into main Apr 27, 2023
@jshlbrd jshlbrd deleted the jshlbrd/feat/compression-readers branch April 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants