Fix IncompatibleReturnValueException in MessageFactoryTest (open-…

…telemetry#1392) PSR7 `RequestInterface::getUri()` must return `UriInterface`, not `string`; explicit typehint was added in `2.0`.
brettmc · Sep 29, 2024 · fd24607 · fd24607
1 parent 20bf3cf
commit fd24607
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/tests/Unit/SDK/Common/Http/Psr/Message/UsesRequestFactoryTrait.php b/tests/Unit/SDK/Common/Http/Psr/Message/UsesRequestFactoryTrait.php
@@ -4,6 +4,7 @@
 
 namespace OpenTelemetry\Tests\Unit\SDK\Common\Http\Psr\Message;
 
+use Nyholm\Psr7\Uri;
 use Psr\Http\Message\RequestFactoryInterface;
 use Psr\Http\Message\RequestInterface;
 
@@ -19,7 +20,7 @@ private function createRequestFactoryMock(?string $requestMethod = 'GET', ?strin
         $request->method('getMethod')
             ->willReturn((string) $requestMethod);
         $request->method('getUri')
-            ->willReturn((string) $requestUri);
+            ->willReturn(new Uri((string) $requestUri));
         $factory = $this->createMock(RequestFactoryInterface::class);
         $factory->method('createRequest')
             ->willReturn($request);

diff --git a/tests/Unit/SDK/Common/Http/Psr/Message/UsesServerRequestFactoryTrait.php b/tests/Unit/SDK/Common/Http/Psr/Message/UsesServerRequestFactoryTrait.php
@@ -4,6 +4,7 @@
 
 namespace OpenTelemetry\Tests\Unit\SDK\Common\Http\Psr\Message;
 
+use Nyholm\Psr7\Uri;
 use Psr\Http\Message\ServerRequestFactoryInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
@@ -19,7 +20,7 @@ private function createServerRequestFactoryMock(?string $requestMethod = 'GET',
         $request->method('getMethod')
             ->willReturn((string) $requestMethod);
         $request->method('getUri')
-            ->willReturn((string) $requestUri);
+            ->willReturn(new Uri((string) $requestUri));
         $factory = $this->createMock(ServerRequestFactoryInterface::class);
         $factory->method('createServerRequest')
             ->willReturn($request);