-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pyproject.toml
and minimal packaging structure
#8
Add a pyproject.toml
and minimal packaging structure
#8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project structure is unfortunately very purposeful, so I can't have this converted into a package; it needs to stay a self-contained file. As such, I don't think having a src
layout is helpful and just makes running the tests a little bit harder by requiring an editable install for not benefit.
Thanks for the PR!
Unfortunately I need this to stay a single file.
Unfortunately I don't want an entry point (see the original issue as to why). |
And FYI Flit supports a single file if Hatch doesn't. |
Thanks for reviewing, no worries leave it with me I'll have another go with your changes 👍🏻 |
Looks like hatch supports a single file package out of the box, I did Also noticed you've now added ruff as a linter. I have a fairly strict Think I addressed all your comments, let me know if you want me to make any further changes 👍🏻 |
I marked all of the requested changes as resolved and refreshed my review. Unfortunately it looks like the changes you made to Thanks for the PR! |
Hey! 👋🏻
Saw this project come up on my GitHub feed and figured it's quick enough for me to help out with some of the issues you've put up.
This PR closes #5
I've put a fairly minimal
pyproject.toml
in using hatch. I've had to restructure the package slightly to make this work (I'm not sure if single file packages are possible, at least I've never done one). I've gone for./src
layout but let me know if you'd like a different layout!Also added
pytest
as a dev dependency with a config I've found useful in my projects. And added an entry point 🙂Let me know if you'd like any changes or have any other comments 👍🏻