make copy in from_string so that string does not move

quinlan-lab/STRling#10
brentp · Oct 16, 2019 · 12b530a · 12b530a
1 parent 428f610
commit 12b530a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,7 @@
+v0.2.23
+=======
++ hts/bam fix from_string for bam record and header. See quinlan-lab/STRling#10
+
 v0.2.22
 =======
 + changes for latest nim

diff --git a/src/hts/bam.nim b/src/hts/bam.nim
@@ -54,13 +54,15 @@ proc copy*(h: Header): Header =
 
 proc from_string*(h:Header, header_string:string) =
     ## create a new header from a string
+    var header_string = header_string
     h.hdr = sam_hdr_parse(header_string.len.cint, header_string.cstring)
     if h.hdr == nil:
         raise newException(ValueError, "error parsing header string:" & header_string)
 
 proc from_string*(r:Record, record_string:string) =
     ## update the record with the given SAM record. note that this does
     ## not make a copy of `record_string` and will modify the string in-place.
+    var record_string = record_string
     if r.hdr == nil:
       raise newException(ValueError, "must set header for record before calling from_string")
     if r.b == nil: