-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor HTTP interface #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
Feature and bug templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull-request is related to the issue #14. The goal is to refator the
atta::io::http
. Previouslly, it was causing problems to build to Windows/MacOS/Web. We decided to switch from cpprestsdk to curlpp, which was proven to be easier to build and use.Current implementation can only do blocking request, but may be extended in the future to support non-blocking requests.
A JSON parser/dumper was also implemented to help dealing with JSON strings.
Http implementation
Now it is only possible to do GET, POST, and PUT requests.
The
Request
andResponse
definitions are:JSON implementation
The implementation is similar to
Section
helper implemented in #13. Examples of how to use the JSON parser/dumper can be found in the JSON unit test file.