Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old versions #358

Closed
wants to merge 2 commits into from
Closed

Drop old versions #358

wants to merge 2 commits into from

Conversation

Silex
Copy link
Contributor

@Silex Silex commented Sep 2, 2019

See #327 first.

@Silex Silex mentioned this pull request Sep 2, 2019
@Silex
Copy link
Contributor Author

Silex commented Sep 2, 2019

@brendon: I'm not sure what to rebase... at the end the only meaningfull diff out of this is:

-    gem "mysql2", "~> 0.4.0"
+    gem "mysql2", "~> 0.4.10", platforms: [:ruby]

@brendon
Copy link
Owner

brendon commented Sep 2, 2019

Hi @Silex, sorry I got in there first and committed a kind-of version of your code. I decided to use the base gem version ~> 0.4.0 as that just translates to whatever the latest patch release is for that version anyway.

@brendon brendon closed this Sep 2, 2019
@Silex Silex deleted the drop-old-versions branch September 2, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants