implement node IDs and autozoom via href anchor #134
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brendan,
I noticed that sometimes people email links to your flamegraph SVGs along with a screenshot of exactly where the sender was looking. So I implemented an href anchor-based ability to bookmark a specific zoomed view so that's it's explicit from just the link.
Here's an example: http://coffeetocode.net/media/example-perf.svg#?zoom=906
I regenerated example-perf.svg using
gunzip -c example-perf-stacks.txt.gz | ./stackcollapse-perf.pl --kernel | ./flamegraph.pl --color=java --hash > example-perf.svg
, but didn't yet do any of the other examples to keep this diff small.Cheers,
PST