Make available the CA certificates via separate package #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. I am glad, that this package is helpful for you, even though the main purpose of this package has been to show case for golang/go#43958. But since there is no progress on this proposal I am happy to extend this package for your additional use case. There is just one little nit to change. |
Did you forget to send that message, or am I looking in the wrong place? What’s the change you’d like to see? :) |
breml
requested changes
Nov 19, 2021
Yup, sorry. Github != Gitlab |
This is useful in situations where you don’t want to *use* the CA certificates in your program, but just *copy* (or embed) the CA certificates elsewhere. Specifically, we’d like to use this in: gokrazy/gokrazy#98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in situations where you don’t want to use the CA certificates
in your program, but just copy (or embed) the CA certificates elsewhere.
Specifically, we’d like to use this in:
gokrazy/gokrazy#98