Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1369 and #1714 Support large amounts of logs #1852

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Fix #1369 and #1714 Support large amounts of logs #1852

merged 4 commits into from
Aug 16, 2024

Conversation

mnapoli
Copy link
Member

@mnapoli mnapoli commented Aug 14, 2024

Fix #1369, Fix #1714

We get rid of symfony/process where we had to forward all the FPM output to PHP. Instead we use proc_open and directly stream output to stdout/stderr.

We get rid of symfony/process where we had to forward all the FPM output to PHP. Instead we use `proc_open` and directly stream output to stdout/stderr.
@mnapoli mnapoli added the bug label Aug 14, 2024
@mnapoli mnapoli changed the title Fix #1369, Fix #1714 Support large amount of logs Fix #1369 Fix #1714 Support large amount of logs Aug 14, 2024
@mnapoli mnapoli changed the title Fix #1369 Fix #1714 Support large amount of logs Fix #1369 and #1714 Support large amount of logs Aug 14, 2024
@allan-simon
Copy link
Contributor

I will try this today , really great news !

@allan-simon
Copy link
Contributor

@mnapoli it works !

@mnapoli
Copy link
Member Author

mnapoli commented Aug 16, 2024

Awesome, thank you for testing!

@mnapoli mnapoli merged commit acfe18b into master Aug 16, 2024
9 checks passed
@mnapoli mnapoli deleted the fpm-logs branch August 16, 2024 17:30
@mnapoli mnapoli changed the title Fix #1369 and #1714 Support large amount of logs Fix #1369 and #1714 Support large amounts of logs Aug 16, 2024
@curlysanders
Copy link

Thank you for your excellent work @mnapoli
Can confirm this is now working like a charm.

@mnapoli
Copy link
Member Author

mnapoli commented Aug 30, 2024

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants