Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide PHP 8.3.0beta1 support #91

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Provide PHP 8.3.0beta1 support #91

merged 4 commits into from
Jul 27, 2023

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jun 7, 2023 •
edited
Loading

WIP: waiting on the download URL, as it will be namespaced to one of the release managers.

UPDATE: When alpha3beta1 is released, this PR should be ready. 🚢

@GrahamCampbell
Copy link
Contributor Author

GrahamCampbell commented Jun 8, 2023 •
edited
Loading

Looks like the mbstring extension does not build. I'm going to comment it out for now, until they get this fixed, so we can move forward with this.

@mnapoli
Copy link
Member

mnapoli commented Jun 12, 2023

Ah I'm guessing there's no xdebug version that supports 8.3 as well?

@GrahamCampbell
Copy link
Contributor Author

I think the master branch may do, if we build from source.

@GrahamCampbell
Copy link
Contributor Author

Let's see if mbstring builds on alpha2, tomorrow.

@GrahamCampbell GrahamCampbell changed the title Provide PHP 8.3.0alpha1 support Provide PHP 8.3.0alpha2 support Jun 23, 2023
@GrahamCampbell GrahamCampbell mentioned this pull request Jun 23, 2023
Closed
@GrahamCampbell
Copy link
Contributor Author

Raised an issue with PHP.

@GrahamCampbell GrahamCampbell changed the title Provide PHP 8.3.0alpha2 support Provide PHP 8.3.0alpha3 support Jun 25, 2023
@GrahamCampbell GrahamCampbell mentioned this pull request Jun 25, 2023
Merged
@GrahamCampbell GrahamCampbell changed the title Provide PHP 8.3.0alpha3 support Provide PHP 8.3.0beta1 support Jul 15, 2023
@GrahamCampbell GrahamCampbell marked this pull request as ready for review July 19, 2023 09:22
@GrahamCampbell
Copy link
Contributor Author

Ready for review, @mnapoli. 🎉

@mnapoli
Copy link
Member

mnapoli commented Jul 26, 2023

Oh the build is green, nice! I was on holidays, catching up today or tomorrow!

@GrahamCampbell
Copy link
Contributor Author

I hope you had a good break! 🏖️🍹

@mnapoli
Copy link
Member

mnapoli commented Jul 27, 2023

Thanks for the great work!

@mnapoli mnapoli merged commit aac4450 into brefphp:main Jul 27, 2023
5 checks passed
@GrahamCampbell GrahamCampbell deleted the php-83 branch July 27, 2023 08:48
@sunaoka sunaoka mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykiwi mykiwi mykiwi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrahamCampbell @mnapoli @mykiwi