Transfer Funds in progress dialog state management #1234
Conversation
erdemyerebasmaz
requested review from
ademar111190,
roeierez,
JssDWt and
ubbabeck
| if (state.transferringOnChainDeposit != true) { | ||
| _pop(); | ||
| if (state.transferringOnChainDeposit != true && _currentRoute.isActive) { | ||
| Navigator.of(context).removeRoute(_currentRoute); |
There was a problem hiding this comment.
I don't think you can access build context in initState.
There was a problem hiding this comment.
These are not accessed in initState per se but after subscription to a stream has established, we're also checking if _currentRoute.isActive beforehand.
It's not really needed on this example but what we can do to make things more robust is scheduling the stream subscription logic once the context is available as such:
WidgetsBinding.instance.addPostFrameCallback((_) {
/// Stream Subscription Logic
});
There was a problem hiding this comment.
Why do we wish to do this in the initstate instead of calling this in didChangeDependencies
There was a problem hiding this comment.
We want to subscribe to the stream only once and didChangeDependencies may be called multiple times per widget lifecycle. We'd need some preventative measures in didChangeDependencies, we do have some examples using _isInit variable on breezmobile.
There was a problem hiding this comment.
Got it, thanks for clarifying.
|
Can we merge that? |
erdemyerebasmaz
deleted the
transfer_funds_in_progress_dialog_state_mgmt
branch
This PR addresses #1232
Instead of popping the last item on navigation stack, the route(dialog) itself is removed if it's active.