Consolidate reverse swap onchain amount arg #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
requested changes
Mar 23, 2024
There was a problem hiding this comment.
Since we always need to store both onchain and invoice amount, it is necessary to grab this information either from response, user input or re-calculation. In this configuration, if the onchain-amount variable is not set in the ReceivePaymentRequest, the insertion will fail due to missing field.
This is meant for a side-branch whose onchain_amount_sat calculation has been changed.
|
You mean #55? That's where this PR's |
ok300
force-pushed
the
ok300-fix-network-flag
branch
from
d906e87
to
382dcb8
Compare
ok300
force-pushed
the
ok300-consolidate-rev-swap-onchain-amt
branch
from
1324935
to
7e5772e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-uses a previously calculated
onchain_amount_satinstead of calculating it again.