Payload compatibility for Expo Notifications #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
LGTM, so we can handle Expo and Firebase payloads by default.
It is the responsibility of the app developer to implement the same for Android, but we should update the docs to support it.
https://sdk-doc-liquid.breez.technology/notifications/android_plugin.html#integrate-the-notification-plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might a bit too Expo specific but the approach isn't bad IMO. Expo offers a API for sending push notifications to Android and iOS without having to worry about APN certificates or Firebase credentials. Because of that, Expo standardizes the payload a little and shoves anything custom to a property called
bodyto avoid interference with Expo own properties.