Wipe storage cache in case of data corrupted issue #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
reviewed
Nov 14, 2024
| Err(lwk_wollet::Error::UpdateHeightTooOld { .. }) => { | ||
| warn!("Update height too old, wipping storage and retrying"); | ||
| let mut path = working_dir.as_ref().to_path_buf(); | ||
| path.push(elements_network.as_str()); |
There was a problem hiding this comment.
I think the passed working_dir is already formatted with the network/fingerprint here:
breez-sdk-liquid/lib/core/src/sdk.rs
Line 156 in 8f3c303
Do we need to add it again?
There was a problem hiding this comment.
Yes but the lwk wallet dir is a nested directory under that directory.
There was a problem hiding this comment.
Ah right, it's the ElementsNetwork, sorry
dangeross
reviewed
Nov 14, 2024
lib/core/src/wallet.rs
Outdated
| let mut path = working_dir.as_ref().to_path_buf(); | ||
| path.push(elements_network.as_str()); | ||
| fs::remove_dir_all(&path)?; | ||
| warn!("Wippping wallet in path: {:?}", path); |
There was a problem hiding this comment.
Suggested change
| warn!("Wippping wallet in path: {:?}", path); | |
| warn!("Wiping wallet in path: {:?}", path); |
| match Wollet::new(elements_network, lwk_persister, descriptor.clone()) { | ||
| Ok(wollet) => Ok(wollet), | ||
| Err(lwk_wollet::Error::UpdateHeightTooOld { .. }) => { | ||
| warn!("Update height too old, wipping storage and retrying"); |
There was a problem hiding this comment.
Suggested change
| warn!("Update height too old, wipping storage and retrying"); | |
| warn!("Update height too old, wiping storage and retrying"); |
dangeross
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.