Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Replaced with "$rootDir" with "$projectDir" #558

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Android: Replaced with "$rootDir" with "$projectDir" #558

merged 1 commit into from
Nov 18, 2024

Conversation

larcho
Copy link
Contributor

@larcho larcho commented Nov 11, 2024

This handles relative paths better. For instance, we use a Monorepo where our node_modules is located somewhere else.

dangeross
dangeross approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested by making the same changes to the installed dependencies of the example app packages/react-native/example/node_modules/@breeztech/react-native-breez-sdk-liquid/android/build.gradle, cleaning then building.

@dangeross dangeross mentioned this pull request Nov 12, 2024
Merged
@dangeross dangeross merged commit f65a8ae into breez:main Nov 18, 2024
8 checks passed
roeierez added a commit that referenced this pull request Nov 19, 2024
@roeierez
Merge commit '02dd93c810226d2c38d71c959cf26e695084f839' into v0.5.0
cb46094 
* commit '02dd93c810226d2c38d71c959cf26e695084f839':
  Add preimage to receive payment (#571)
  Add support for paying to BOLT12 (#549)
  Fix swift URL init compatibility (#569)
  Configurable cache dir (#567)
  Android: Replaced  with (#558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangeross dangeross dangeross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larcho @dangeross