Retry chain swap server lockup tx verification #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Nov 10, 2024
lib/core/src/chain_swap.rs
Outdated
| let claim_details = chain_swap.get_boltz_create_response()?.claim_details; | ||
| let retries = if verify_confirmation { 30 } else { 0 }; | ||
| let mut retry = 0; | ||
| loop { |
There was a problem hiding this comment.
The concern here is that it will block the event status polling loop and may block other payment statuses.
There was a problem hiding this comment.
I think it would take a only couple of attempts to get the confirmation, it testing it was confirmed in the first request. Maybe it's better to add it to the tracking thread to verify and claim if needed
dangeross
force-pushed
the
savage-retry-server-tx-verify
branch
from
e9afbd1
to
18a6427
Compare
dangeross
force-pushed
the
savage-retry-server-tx-verify
branch
from
18a6427
to
1ba233d
Compare
|
I was able to catch a failed confirmation and see it picked up in the monitoring thread |
ok300
approved these changes
Nov 11, 2024
roeierez
added a commit
that referenced
this pull request
Nov 17, 2024
* commit '1cbe6d7a8045df6474eba131a298df30e066c84f': fix typo fix clilppy wipe storage cache in case of data corrupted issue Log errors on starting an SDK instance (#565) Notify success when waiting for claim confirmation (#562) Validate the pay_onchain address (#561) Liquid/Lightning drain (#553) Monitor server lockup tx in thread to verify/claim (#557) Update README.md Fix chronological order of `list_payments` (#552) Onchain payment flow: add more logging (#551) Store claim_address for incoming chain swap when claiming (#548)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retries adds monitoring of the incoming server lockup txs. If a server lockup tx is confirmed without a claim (tx failed verification when receiving the Boltz status), then perform the claim.
Fixes #547