Fix inbound_liquidity_msats
#1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgranhao
force-pushed
the
05-08-2024-fix-inbound-liquidity-msats
branch
from
515f632 to
25b7b4e
Compare
ok300
approved these changes
Aug 5, 2024
JssDWt
reviewed
Aug 5, 2024
danielgranhao
force-pushed
the
05-08-2024-fix-inbound-liquidity-msats
branch
from
13913a3 to
ee25097
Compare
roeierez
reviewed
Aug 5, 2024
| @@ -187,6 +187,7 @@ dictionary NodeState { | |||
| u64 max_single_payment_amount_msat; | |||
| u64 max_chan_reserve_msats; | |||
| sequence<string> connected_peers; | |||
| u64 max_receivable_single_payment_amount_msat; | |||
There was a problem hiding this comment.
Now that we add this field the former one (inbound_liquidity_msats) changes its semantic.
My concern is that developers will upgrade and their logic will break without them knowing about it.
Can we rename the inbound_liquidity_msats so developers will get a compilation error on upgrade which will force them to change the code?
We can also leave it with the old semantic (and mark it as deprecated) and add another field (total_inbound_liquidity_msat) with the unified liquidity.
Anything that will not let this change go under the radar.
There was a problem hiding this comment.
That's a very good point @roeierez. I'll rename it to total_inbound_liquidity_msat.
danielgranhao
force-pushed
the
05-08-2024-fix-inbound-liquidity-msats
branch
from
8e43501 to
544c928
Compare
danielgranhao
force-pushed
the
05-08-2024-fix-inbound-liquidity-msats
branch
from
544c928 to
c51d212
Compare
roeierez
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1018