Skip to content

Commit

Permalink
pdf output fix
Browse files Browse the repository at this point in the history
  • Loading branch information
breck7 committed Jan 7, 2025
1 parent 041ebff commit 37b4bca
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "scroll-cli",
"version": "165.1.0",
"version": "165.1.1",
"description": "A language for scientists of all ages. A curated collection of tools for refining and sharing thoughts.",
"main": "scroll.js",
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion parsers/pdf.parsers
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ buildPdfParser
const { filename } = root
const outputFile = root.filenameNoExtension + ".pdf"
// relevant source code for chrome: https://github.com/chromium/chromium/blob/a56ef4a02086c6c09770446733700312c86f7623/components/headless/command_handler/headless_command_switches.cc#L22
const command = `/Applications/Google\\ Chrome.app/Contents/MacOS/Google\\ Chrome --headless --disable-gpu --no-pdf-header-footer --default-background-color=00000000 --no-pdf-background --print-to-pdf="${outputFile}" "${this.permalink}"`
const command = `/Applications/Google\\ Chrome.app/Contents/MacOS/Google\\ Chrome --headless --disable-gpu --no-pdf-header-footer --default-background-color=00000000 --no-pdf-background --print-to-pdf="${outputFile}" "${root.permalink}"`
// console.log(`Node.js is running on architecture: ${process.arch}`)
try {
const output = require("child_process").execSync(command, { stdio: "ignore" })
Expand Down
3 changes: 3 additions & 0 deletions releaseNotes.scroll
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ ciBadges.scroll
br
thinColumns

📦 165.1.1 1/06/2025
🏥 fix regression in pdf building

📦 165.1.0 1/06/2025
🎉 support larger data science sessions by using memory if not enough local storage

Expand Down

0 comments on commit 37b4bca

Please sign in to comment.