Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkrelease: explicitly use gzip for tarball generation #904

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Mar 31, 2023

  1. mkrelease: explicitly use gzip for tarball generation

    Since git v2.38.0 git archive tar.gz format default has changed from
    invoking gzip to an internal gzip compressor implementation. However,
    the output bitstream is not identical, meaning the resulting tar.gz
    archive's checksum is different. This causes problems for PGP signing.
    
    In order to avoid this issue for both old and new archive generation
    alike manually invoke gzip in mkrelease script, bypassing git archive's
    internal compression logic completely regardless of version.
    
    GitHub and others presumably use a similar method to deal with this
    change to keep old tag archive checksums from changing.
    
    * git/git@4f4be00
    * https://github.blog/changelog/2023-01-30-git-archive-checksums-may-change/
    * https://github.com/orgs/community/discussions/45830
    * bazel-contrib/SIG-rules-authors#11
    vermeeren committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    68e9dc4 View commit details
    Browse the repository at this point in the history