-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx 3.5 compatibility #640
Conversation
Signed-off-by: Fabio Utzig <[email protected]>
Add Sphinx 3.5.0 and change 3.4.x branch to 3.5.x. This should fix the broken CI. Signed-off-by: Fabio Utzig <[email protected]>
@vermeeren TBH I have not tested with Sphinx 3.5.0, haven't even seen it came out before just now. But I don't see a reason for it not working, and even if it has failures, it will need to be fixed anyway, so this should be fine. |
@jakobandersen Any changes that you know of on the Sphinx side that need some adaptation over here? Seems fine to me as the CI is working nicely. |
No, I think it should work fine. |
@jakobandersen Will do, thanks for the quick reply. |
As this issue prevents those using Sphinx 3.5.0 + breathe, I'm kindly wondering when the next breathe release will be? |
PS. Sphinx 3.5.1 was released moments ago... |
@jmckenna I intended to release after the current 2 PRs had been merged, but I agree the compatibility update is needed earlier. Just released v4.27.0 containing this fix. |
thanks @vermeeren ! I appreciate this. |
This should fix the failures seen on #638 and #639