Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Added decorators to hide passwords for django error emails #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rsgm
Copy link

@Rsgm Rsgm commented Jan 28, 2016

I am always getting error emails on the signin page with sensitive information.

I know this does not fix the root of my problem, but I want to make sure that there is no future error emails with users' passwords in plain text.

@swistakm
Copy link
Contributor

Sorry for waiting so long but there was obvious syntax error under Python 3.2 so I just waited for a fix. Can you show how email now looks with the change? How about providing settings variable for developers that still want passwords sent by email?

@swistakm
Copy link
Contributor

Oh, sorry I just noticed that this is about error emails...

@swistakm swistakm added the bug label Mar 22, 2016
@swistakm swistakm added this to the 2.0.1 milestone Mar 22, 2016
@Rsgm
Copy link
Author

Rsgm commented Mar 22, 2016

Thank you for adding this to the milestone. I was not aware of the 3.2 syntax change, which explains the failing test. I can fix this later tonight.

@swistakm
Copy link
Contributor

No problem. I just have updated the v2.0.x branch and when it passes test I will prepare a new release.

@swistakm
Copy link
Contributor

It seems that this is rather issue with our Travis build configuration (pip dropped support for Python 3.2 in 8.0.0) version. I will try to fix that in 2.0.0 sou you will need only to rebase your PR once it is done.

@swistakm swistakm modified the milestones: 2.0.2, 2.0.1 Mar 23, 2016
@Rsgm
Copy link
Author

Rsgm commented Aug 12, 2016

Sorry it took so long, I completely forgot about this. Anyway it's a tiny change and it's ready to merge.

@coveralls
Copy link

coveralls commented Aug 12, 2016

Coverage Status

Coverage increased (+0.03%) to 95.595% when pulling 5597fb7 on Rsgm:master into c6ede5f on bread-and-pepper:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.595% when pulling ee4185a on Rsgm:master into 7dfb3d5 on bread-and-pepper:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants