Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded comment from redirect file #8728

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Jan 9, 2025

Why are you making this change? (required)

Accidentally left a comment on the redirect file during #8680. Removing in this PR.

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@internetisaiah internetisaiah self-assigned this Jan 9, 2025
@cla-bot cla-bot bot added the cla-signed label Jan 9, 2025
@internetisaiah internetisaiah requested a review from a team January 9, 2025 02:27
@rachel-feinberg rachel-feinberg marked this pull request as ready for review January 9, 2025 17:02
Copy link
Contributor

@rachel-feinberg rachel-feinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@rachel-feinberg rachel-feinberg merged commit 5b4e1be into develop Jan 9, 2025
7 checks passed
@rachel-feinberg rachel-feinberg deleted the internetisaiah-patch-5 branch January 9, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants