Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BD-3790 Apply template standards to Custom Data #8667

Merged
merged 2 commits into from
Jan 6, 2025
Merged

BD-3790 Apply template standards to Custom Data #8667

merged 2 commits into from
Jan 6, 2025

Conversation

rachel-feinberg
Copy link
Contributor

Why are you making this change? (required)

Apply Diataxis standards to Custom Data.

Related PRs, issues, or features (optional)

BD-3790

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@rachel-feinberg rachel-feinberg self-assigned this Dec 20, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 20, 2024
@rachel-feinberg rachel-feinberg requested a review from a team December 20, 2024 23:53
internetisaiah
internetisaiah requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Left a few suggestions 🫡

_docs/_user_guide/data_and_analytics/custom_data/custom_attributes.md Outdated Show resolved Hide resolved
...er_guide/data_and_analytics/custom_data/custom_attributes/nested_custom_attribute_support.md Show resolved Hide resolved
...er_guide/data_and_analytics/custom_data/custom_attributes/nested_custom_attribute_support.md Outdated Show resolved Hide resolved
...er_guide/data_and_analytics/custom_data/custom_attributes/nested_custom_attribute_support.md Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/custom_events/nested_objects.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/custom_events/nested_objects.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/event_naming_conventions.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/custom_data/events.md

- [Standard events](#standard-events): Provide a basic understanding of user engagement with your app or site.
- [Purchase events](#purchase-events): Crucial for understanding user purchasing behavior and for tracking revenue.
- [Custom events](#custom-events): Provide deeper insight into user behaviors that are unique to your app or business.

By tracking these different types of events, you can gain a deeper understanding of your users, which can inform your marketing strategies, help you optimize your app, and enable you to provide a more personalized user experience. Let's dive in.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original (with a .) is hilarious to me 😂

lydia-xie
lydia-xie approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! :)

@lydia-xie lydia-xie merged commit 93eaa64 into develop Jan 6, 2025
7 checks passed
@lydia-xie lydia-xie deleted the bd-3790 branch January 6, 2025 19:04
@rachel-feinberg rachel-feinberg mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lydia-xie lydia-xie lydia-xie approved these changes

@internetisaiah internetisaiah Awaiting requested review from internetisaiah

Assignees

@rachel-feinberg rachel-feinberg

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachel-feinberg @lydia-xie @internetisaiah