Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional updates for microsoft fabric documentation #8618

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

colleenkerr
Copy link
Contributor

@colleenkerr colleenkerr commented Dec 11, 2024

Why are you making this change? (required)

Adding documentation for other CDI functionality supported by Azure Fabric

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

This feature is in EA on 12/12. If these changes can go out with that docs release that would be great - otherwise, the following release is ok.

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@andrewcarlberg andrewcarlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asimonutti do you want to see this?

@josh-mccrowell-braze
Copy link
Collaborator

Changes look good to me aside from minor nitpicks! Holding off in case @asimonutti has edits. Will merge before EOD 12/12.

@asimonutti
Copy link
Contributor

Changes look good to me aside from minor nitpicks! Holding off in case @asimonutti has edits. Will merge before EOD 12/12.

Taking a look now!

@asimonutti
Copy link
Contributor

LGTM

@josh-mccrowell-braze josh-mccrowell-braze merged commit 37333bb into develop Dec 12, 2024
7 checks passed
@josh-mccrowell-braze josh-mccrowell-braze deleted the ck-fabric-other-docs branch December 12, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants