Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3744 Generalize mobile push page #8608

Merged
merged 5 commits into from
Dec 12, 2024
Merged

BD-3744 Generalize mobile push page #8608

merged 5 commits into from
Dec 12, 2024

Conversation

rachel-feinberg
Copy link
Contributor

Why are you making this change? (required)

Update documentation to be more broad as this is not specifically for safari only, but includes chrome, edge, and firefox as well.

Related PRs, issues, or features (optional)

BD-3744

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@rachel-feinberg rachel-feinberg self-assigned this Dec 11, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 11, 2024
@rachel-feinberg rachel-feinberg requested review from lydia-xie and removed request for lydia-xie December 11, 2024 22:32
@lydia-xie
Copy link
Contributor

There's a merge conflict, but other than that lgtm!

@rachel-feinberg rachel-feinberg merged commit d33b948 into develop Dec 12, 2024
7 checks passed
@rachel-feinberg rachel-feinberg deleted the bd-3744 branch December 12, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants