Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO-3068: update catalogs settings docs for price drop and back in stock #8541

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

LiZhangBraze
Copy link
Contributor

@LiZhangBraze LiZhangBraze commented Dec 3, 2024

Why are you making this change? (required)

Update the docs and images related to the catalogs settings for price drop and back in stock.
CO-3068

Related PRs, issues, or features (optional)

CO-3068
Related PR

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link

cla-bot bot commented Dec 3, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

@LiZhangBraze LiZhangBraze marked this pull request as ready for review December 3, 2024 20:36
@LiZhangBraze LiZhangBraze requested review from mkigikm, HVisagie, a team and lydia-xie and removed request for a team December 3, 2024 20:36
@lydia-xie
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Dec 3, 2024
Copy link

cla-bot bot commented Dec 3, 2024

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my end! let me know when it's ready to merge 👍

@lydia-xie lydia-xie self-assigned this Dec 3, 2024
@LiZhangBraze
Copy link
Contributor Author

This should be merged once the frontend changes make it to prod. Is that right?

@lydia-xie
Copy link
Contributor

Yep! We have our docs deployment tomorrow afternoon, so if this change is live in Braze, then this PR can be merged :)

@LiZhangBraze
Copy link
Contributor Author

According to the freeze schedule, this change should be released sometime today/tomorrow, but I only see the changes in olaf so far.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-pt-br ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 0:45am

@lydia-xie lydia-xie merged commit c6ea623 into develop Dec 10, 2024
6 checks passed
@lydia-xie lydia-xie deleted the CO-3068 branch December 10, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants