-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crypto Tests & Reorganize files #470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few nits for the Wallet Desktop checklist. Looks good overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ from me, thanks for addressing my nits and feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ for Android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes: #425
Changes in the PR
SampleBookmarks/
WikiTemplate/
WikiTemplate
root folderReview Request
Testrun generator
brave_test_generator.py
file. Please check for path for existing testrun and make sure nothing errors out.Crypto Wallet (Desktop)
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md
. Test added based on the new onboarding flow and existing feature. Pending tasks is for the Buy/Send/Swap widget. Will update it once the new Swap UI lands.Crypto Wallet (Android)
WikiTemplate/Crypto/wikitemplate-cryptoAndroid.md
. Please suggest any areas that may regress and needs to be checkedCrypto Wallet (iOS)
WikiTemplate/Crypto/wikitemplate-cryptoiOS.md
. Please suggest any areas that may regress and needs to be checked. Will add a follow up PR if anything is missing/needs update