Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crypto Tests & Reorganize files #470

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

srirambv
Copy link
Contributor

@srirambv srirambv commented Sep 4, 2022

Fixes: #425

Changes in the PR

  • Added Crypto Wallets Regression test cases for Desktop/Android/iOS
  • Reorganized files into folders
    • Moved bookmark files under SampleBookmarks/
    • Moved all Wiki template files under WikiTemplate/
    • Separated out each platform/feature wiki file under nested folder inside WikiTemplate root folder

Review Request

  • Testrun generator

    • @brave/legacy_qa please review the brave_test_generator.py file. Please check for path for existing testrun and make sure nothing errors out.
  • Crypto Wallet (Desktop)

  • Crypto Wallet (Android)

    • @Pavneet-Sing @SergeyZhukovsky please review WikiTemplate/Crypto/wikitemplate-cryptoAndroid.md. Please suggest any areas that may regress and needs to be checked
  • Crypto Wallet (iOS)

    • @nuo-xu @StephenHeaps please review WikiTemplate/Crypto/wikitemplate-cryptoiOS.md. Please suggest any areas that may regress and needs to be checked. Will add a follow up PR if anything is missing/needs update

Copy link

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few nits for the Wallet Desktop checklist. Looks good overall

WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stephendonner stephendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ from me, thanks for addressing my nits and feedback

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for Android

WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
WikiTemplate/Crypto/wikitemplate-cryptoDesktop.md Outdated Show resolved Hide resolved
@kjozwiak kjozwiak self-requested a review October 5, 2022 22:44
Copy link

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@srirambv srirambv merged commit 97c298b into brave:master Oct 17, 2022
@srirambv srirambv deleted the crypto branch October 17, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression list for Wallet
10 participants