Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icons]: Add support for quadratic icons #930

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

fallaciousreasoning
Copy link
Collaborator

brave-core build doesn't work with the latest version of Leo because one of the icons it references is using a quadratic path. This updates the .svg ==> .icon converter to support quadratic paths.

You can test the support by opening leo_reading_list_add.icon from main in https://skia-icon-editor.vercel.app/

Additionally, it should crash the build if we encounter more unknown commands, which should prevent us merging any new broken icons

Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 Thanks for Submitting! This PR is available for preview at the link below.

✅ PR tip preview: https://930.pr.nala.bravesoftware.com/
✅ Commit preview: https://930.pr.nala.bravesoftware.com/commit-ef73b54e7a6e4b41038bbe1de5076353de67b907/

- ./tokens/css/variables-android.old.css: 7390 bytes
+ ./tokens/css/variables-android.css: 7390 bytes
---
- ./tokens/css/variables-browser.old.css: 6848 bytes
+ ./tokens/css/variables-browser.css: 6848 bytes
---
- ./tokens/css/variables-ios.old.css: 7033 bytes
+ ./tokens/css/variables-ios.css: 7033 bytes
---
- ./tokens/css/variables-marketing.old.css: 13501 bytes
+ ./tokens/css/variables-marketing.css: 13501 bytes
---
- ./tokens/css/variables-news.old.css: 526 bytes
+ ./tokens/css/variables-news.css: 526 bytes
---
- ./tokens/css/variables-newtab.old.css: 1933 bytes
+ ./tokens/css/variables-newtab.css: 1933 bytes
---
- ./tokens/css/variables-search.old.css: 2409 bytes
+ ./tokens/css/variables-search.css: 2409 bytes
---
- ./tokens/css/variables-web3.old.css: 905 bytes
+ ./tokens/css/variables-web3.css: 905 bytes
---
- ./tokens/css/variables.old.css: 119512 bytes
+ ./tokens/css/variables.css: 119512 bytes
Variables Diff: variables-android.diff
--- ./tokens/css/variables-android.old.css	2024-12-06 01:05:17.057051770 +0000
+++ ./tokens/css/variables-android.css	2024-12-06 01:04:39.257133806 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-browser.diff
--- ./tokens/css/variables-browser.old.css	2024-12-06 01:05:17.445050884 +0000
+++ ./tokens/css/variables-browser.css	2024-12-06 01:04:39.233133796 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-ios.diff
--- ./tokens/css/variables-ios.old.css	2024-12-06 01:05:17.749050191 +0000
+++ ./tokens/css/variables-ios.css	2024-12-06 01:04:39.273133814 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-marketing.diff
--- ./tokens/css/variables-marketing.old.css	2024-12-06 01:05:18.089049416 +0000
+++ ./tokens/css/variables-marketing.css	2024-12-06 01:04:39.293133823 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-news.diff
--- ./tokens/css/variables-news.old.css	2024-12-06 01:05:18.385048728 +0000
+++ ./tokens/css/variables-news.css	2024-12-06 01:04:39.321133835 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-newtab.diff
--- ./tokens/css/variables-newtab.old.css	2024-12-06 01:05:18.685048032 +0000
+++ ./tokens/css/variables-newtab.css	2024-12-06 01:04:39.329133838 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-search.diff
--- ./tokens/css/variables-search.old.css	2024-12-06 01:05:18.973047362 +0000
+++ ./tokens/css/variables-search.css	2024-12-06 01:04:39.313133832 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {
Variables Diff: variables-web3.diff
--- ./tokens/css/variables-web3.old.css	2024-12-06 01:05:19.273046666 +0000
+++ ./tokens/css/variables-web3.css	2024-12-06 01:04:39.337133842 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 @media (prefers-color-scheme: light) {
Variables Diff: variables.diff
--- ./tokens/css/variables.old.css	2024-12-06 01:05:19.569045978 +0000
+++ ./tokens/css/variables.css	2024-12-06 01:04:39.097133736 +0000
@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Wed Dec 04 2024 03:46:11 GMT+0000 (Coordinated Universal Time)
+ * Generated on Fri Dec 06 2024 01:04:39 GMT+0000 (Coordinated Universal Time)
  */
 
 :root {

@fallaciousreasoning fallaciousreasoning merged commit 5d2b395 into main Dec 6, 2024
6 checks passed
@fallaciousreasoning fallaciousreasoning deleted the unknown-icons-crash branch December 6, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants