Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show Flash notification bar if page loads small/hidden Flash elements #7528

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 8, 2017

Fix #7523

Test Plan:

  1. automated flash tests should pass
  2. go to a site that has an invisible Flash object. If Flash is globally enabled, it should show the notification bar. @srirambv or @alexwykoff may have an example of such a site.
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #7523

Test Plan:
1. automated flash tests should pass
@bbondy
Copy link
Member

bbondy commented Mar 11, 2017

++ thanks

@srirambv
Copy link
Collaborator

Can use www.wordtimebuddy.com which has a small flash element
image

@diracdeltas
Copy link
Member Author

actually https://www.worldtimebuddy.com/'s flash element is greater than 20px so it doesn't trigger the notification bar. reverso.net is a good example once #7752 is merged.

@diracdeltas diracdeltas deleted the feature/7523 branch March 26, 2017 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants