Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Only allow whitelisted protocols to load in tor tabs #14665

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jul 5, 2018

fix #14664

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@riastradh-brave
Copy link
Contributor

Can we provide some more obvious feedback than a message to the console? Right now with this branch Brave acts like it has completely ignored the input altogether in the UI.

@diracdeltas
Copy link
Member Author

@riastradh-brave done!

@bsclifton bsclifton merged commit 6a9a158 into master Jul 6, 2018
@bsclifton bsclifton deleted the fix/tor-whitelist-protocol branch July 6, 2018 16:20
bsclifton added a commit that referenced this pull request Jul 6, 2018
Only allow whitelisted protocols to load in tor tabs
bsclifton added a commit that referenced this pull request Jul 6, 2018
Only allow whitelisted protocols to load in tor tabs
@bsclifton
Copy link
Member

master 6a9a158
0.24.x 97d904d
0.23.x 96fbc2d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hackerone] file:// URL issue
3 participants