Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autofill crash when adding credit card (after upgrade) #4208

Closed
bsclifton opened this issue Sep 22, 2016 · 0 comments · Fixed by #4215
Closed

Autofill crash when adding credit card (after upgrade) #4208

bsclifton opened this issue Sep 22, 2016 · 0 comments · Fixed by #4215
Assignees
@darkdh
Labels
crash feature/autofill QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Milestone
0.12.2dev

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 22, 2016 •
edited
Loading

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Adding credit card causes a crash. Does not happen if I have a fresh session (ex: I remove my session-store-1 file and allow Brave to create a new one)

Expected behavior:
Warning is shown if data is invalid or data is added

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 Pro x64
  • Brave Version:
    0.12.2 RC2

My previous installed version before upgrading was 0.12.1 and I had no autofill data stored. (I can share my session privately if unable to repro)

  • Steps to reproduce:
    1. Launch Brave, go to about:autofill
    2. Click "Add Credit Card"
    3. For Name put Brian, for Card Number put 123457890123456, leave Expiration date as default value of 01/2016
    4. Click Save
    5. Brave crashes
  • Screenshot if needed:
    autofill-crash
  • Any related issues:
@bsclifton bsclifton added this to the 0.12.2dev milestone Sep 22, 2016
@bsclifton bsclifton changed the title Autofill crash when adding credit card Autofill crash when adding credit card (after upgrade) Sep 22, 2016
@darkdh darkdh self-assigned this Sep 23, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 23, 2016
@darkdh
Autofill guid migration
cdd785a 
fix brave#4208, brave#4209

Auditors: @bridiver, @bbondy

Test Plan:
1. Create autofill data from "0.12.1" and close brave
2. Copy "session-store-1" and "Web Data" to somewhere else
3. Copy the files in step 2 to your brave folder
4. Lauch brave "0.12.2"
5. Autofill data created from "0.12.1" should be listed in "about:autofill"
6. Should be able to add new autofill data
@darkdh darkdh mentioned this issue Sep 23, 2016
Merged
4 tasks
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
crash feature/autofill QA/checked-Linux QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging a pull request may close this issue.

Autofill guid migration darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv