Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark folder names should contain visible text #3347

Closed
alexwykoff opened this issue Aug 23, 2016 · 3 comments
Closed

Bookmark folder names should contain visible text #3347

alexwykoff opened this issue Aug 23, 2016 · 3 comments

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
While verifying #3188, I found it was possible to create folder names which are whitespace.

Expected behavior:
We should probably have the user input something resembling visible text.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    0.11.6 pre-beta2
  • Steps to reproduce:
    1. Select 'Add folder...' from the bookmark tray context menu.
    2. Type '' for the name.
    3. Save the folder.
  • Screenshot if needed:
    whitespace_folders
  • Any related issues:
@bbondy
Copy link
Member

bbondy commented Aug 24, 2016

let's just trim the input before saving it and validating it.

@luixxiul
Copy link
Contributor

I'm not sure if this is related, but you cannot delete the folder created following the STR by clicking "Delete" in the dialog displayed with "Edit Bookmark". "Delete Folder" in the context menu on the folder works.

@bbondy
Copy link
Member

bbondy commented Aug 25, 2016

It's an indepdent bug, please post that as a new bug @luixxiul, thanks!

@bbondy bbondy closed this as completed in 575ea0c Aug 25, 2016
bbondy added a commit that referenced this issue Aug 25, 2016
Do not let empty spaced bookmark title fixes #3347
@luixxiul luixxiul added this to the 0.11.6dev milestone Aug 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants