Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

memory leak warning when ~10+ tabs are open #18

Closed
diracdeltas opened this issue Dec 8, 2015 · 1 comment
Closed

memory leak warning when ~10+ tabs are open #18

diracdeltas opened this issue Dec 8, 2015 · 1 comment

Comments

@diracdeltas
Copy link
Member

When I open 10 or so tabs in the browser, I get this error repeatedly:

> [email protected] start /Users/yan/repos/browser-electron
> NODE_ENV=development electron . --debug=5858

(node) warning: possible EventEmitter memory leak detected. 11 crashed listeners added. Use emitter.setMaxListeners() to increase limit.
Trace
    at EventEmitter.addListener (events.js:239:17)
    at EventEmitter.once (events.js:265:8)
    at createGuest (/Users/yan/repos/browser-electron/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/atom.asar/browser/lib/guest-view-manager.js:51:16)
    at EventEmitter.<anonymous> (/Users/yan/repos/browser-electron/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/atom.asar/browser/lib/guest-view-manager.js:167:66)
    at emitThree (events.js:97:13)
    at EventEmitter.emit (events.js:175:7)
    at EventEmitter.<anonymous> (/Users/yan/repos/browser-electron/node_modules/electron-prebuilt/dist/Electron.app/Contents/Resources/atom.asar/browser/api/lib/web-contents.js:85:27)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)
@bbondy
Copy link
Member

bbondy commented Dec 9, 2015

What's worse and related is that if you open / close 11 times in a row you'll get the same.
I'm going to try doing the per frame listeners once and then setting state in the active frame only for the pendingShortcut from the store. On prop changes we would detect and do the action.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants