-
Notifications
You must be signed in to change notification settings - Fork 972
Lazy load Tor instead of at startup #14617
Comments
It used to be lazy load but we change it to asynchronous launching from launcher thread at browser startup mainly because tor startup takes time and often unpredictable so users will experience opening a tor tab but unable to use it and see proxy connection error. So launching tor at startup won’t let users suffer from this most of the time. |
@diracdeltas and @riastradh-brave can elaborate ^ if I missed anything |
The startup is slowest the first time around; then tor caches some network information that enables it to start up faster the next time around. Another option would be to automatically start Tor (which, except for a couple of directory creations, is asynchronous) only for users who have chosen to use Tor in some way, as long as there is a configuration doohickey for turning it back off. |
Verified on Windows 10 x64 using
|
Verified on macOS using
|
Verified on XUbuntu 18.04 x64 using
|
Test plan
See #14668
Description
Currently Tor is loaded always at startup, but not everyone wants Tor.
This negatively affects startup time and also bypasses the ability to not use Tor which is important especially for corporate users.
Steps to Reproduce
Actual result:
You can see Tor logging
Expected result:
You only see Tor logging once the first private tab is opened.
Reproduces how often:
Always at startup
Brave Version
about:brave info:
Brave: 0.23.19
V8: 6.7.288.46
rev: 178c3fb
Muon: 7.1.3
OS Release: 17.5.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Tor: 0.3.3.7 (git-035a35178c92da94)
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.87
Reproducible on current live release:
Yes
Additional Information
The text was updated successfully, but these errors were encountered: