Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

session tab icons overlapping #14553

Closed
kjozwiak opened this issue Jun 26, 2018 · 2 comments
Closed

session tab icons overlapping #14553

kjozwiak opened this issue Jun 26, 2018 · 2 comments
Assignees
Labels
0.23.x issue first seen in 0.23.x feature/session-tabs priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 regression release-notes/exclude

Comments

@kjozwiak
Copy link
Member

Description

When opening a session tabs, you'll notice that the # icon is overlapping the session icons.

Steps to Reproduce

  1. launch 0.23.17 bc754eb
  2. open a new session tab

Actual result:

screen shot 2018-06-22 at 12 29 24 am

Expected result:

screen shot 2018-06-25 at 10 12 35 pm

Reproduces how often:

100% reproducible using the above STR.

Brave Version

about:brave info:

Brave: 0.23.17 
V8: 6.7.288.46 
rev: bc754ebe4dd8d8f59a322660e8af1962a99753ea 
Muon: 7.1.2 
OS Release: 17.5.0 
Update Channel: Release 
OS Architecture: x64 
OS Platform: macOS 
Node.js: 7.9.0 
Tor: 0.3.3.7 (git-035a35178c92da94) 
Brave Sync: v1.4.2 
libchromiumcontent: 67.0.3396.87

Reproducible on current live release:

Currently only reproducible on 0.23.x and not 0.22.810 which is the latest released version.

Additional Information

@petemill
Copy link
Member

I believe this is a clash with this PR: #13785 which seems to not have a milestone but is contained within 0.23. I can fix.

@alexwykoff alexwykoff added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Jun 26, 2018
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 27, 2018

Verified on Windows 10 x64
• 0.23.19 178c3fb
• Muon 7.1.3
• libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.19 178c3fb
  • Muon 7.1.3
  • libchromiumcontent: 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.19 178c3fb
  • Muon 7.1.3
  • libchromiumcontent 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.23.x issue first seen in 0.23.x feature/session-tabs priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 regression release-notes/exclude
Projects
None yet
Development

No branches or pull requests

6 participants