Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Opening a link in new private tab doesn't load over tor network #14103

Closed
srirambv opened this issue May 12, 2018 · 2 comments
Closed

Opening a link in new private tab doesn't load over tor network #14103

srirambv opened this issue May 12, 2018 · 2 comments
Assignees
@diracdeltas
Labels
0.23.x issue first seen in 0.23.x bug feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

Description

Opening a link in new private tab doesn't load over tor network

Steps to Reproduce

  1. Clean install 0.23.4
  2. Open a private tab and load check.torproject.org, shows Congratulations. This browser is configured to use Tor. Ensure IP is not your local public IP
  3. Open a normal tab, search for check tor
  4. Right click on check.torproject.org and open in a New Private tab
  5. Page isn't loaded over tor network, shows Sorry. You are not using Tor. and shows your actual public IP address

Actual result:
Opening a link in new private tab doesn't load over tor network

Expected result:
Should load all links over tor network even if link is opened via context menu from a normal/session tab

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.23.4
V8 6.6.346.26
rev b355561
Muon 6.1.1
OS Release 10.0.16299
Update Channel Developer
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
libchromiumcontent 66.0.3359.139

Reproducible on current live release:
N/A

Additional Information

cc: @diracdeltas @jumde @riastradh-brave @darkdh
@srirambv srirambv added this to the 0.23.x (Developer Channel) milestone May 12, 2018
@diracdeltas diracdeltas self-assigned this May 12, 2018
diracdeltas added a commit that referenced this issue May 17, 2018
@diracdeltas
Open link in new private tab should use tor if enabled
5650e12 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
@diracdeltas
Copy link
Member

fixed by 5650e12

diracdeltas added a commit that referenced this issue May 17, 2018
@diracdeltas
Open link in new private tab should use tor if enabled
63f1bea 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
diracdeltas added a commit that referenced this issue May 22, 2018
@diracdeltas
Open link in new private tab should use tor if enabled
0172660 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
diracdeltas added a commit that referenced this issue Jun 8, 2018
@diracdeltas
Open link in new private tab should use tor if enabled
0820b3d 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
This was referenced Jun 11, 2018
Closed
Closed
Closed
diracdeltas added a commit that referenced this issue Jun 12, 2018
@diracdeltas
Open link in new private tab should use tor if enabled
b80d583 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
@btlechowski
Copy link
Contributor

btlechowski commented Jun 13, 2018 •
edited by kjozwiak
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Windows 10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.12 88f6f07
  • muon: 7.1.1
  • libchromiumcontent: 67.0.3396.87

petemill pushed a commit that referenced this issue Jun 15, 2018
@diracdeltas @petemill
Open link in new private tab should use tor if enabled
fd1893d 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
@srirambv srirambv mentioned this issue Jun 19, 2018
Closed
This was referenced Jun 21, 2018
Closed
Closed
Closed
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@diracdeltas @bsclifton
Open link in new private tab should use tor if enabled
80286fa 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@diracdeltas @bsclifton
Open link in new private tab should use tor if enabled
203a9ef 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
This was referenced Jun 21, 2018
Closed
Closed
Closed
bsclifton pushed a commit that referenced this issue Jun 22, 2018
@diracdeltas @bsclifton
Open link in new private tab should use tor if enabled
ab9dbd0 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
diracdeltas added a commit that referenced this issue Jun 22, 2018
@diracdeltas
Open link in new private tab should use tor if enabled
3ad7923 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
bsclifton pushed a commit that referenced this issue Jun 23, 2018
@diracdeltas @bsclifton
Open link in new private tab should use tor if enabled
30501d3 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
bsclifton pushed a commit that referenced this issue Jun 25, 2018
@diracdeltas @bsclifton
Open link in new private tab should use tor if enabled
1207dfb 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
bsclifton pushed a commit that referenced this issue Jun 26, 2018
@diracdeltas @bsclifton
Open link in new private tab should use tor if enabled
123b566 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@diracdeltas @bsclifton
Open link in new private tab should use tor if enabled
4c989bf 
fix #14103

Test Plan:
1. make sure tor tabs is enabled
2. go to a link and right-click 'open in new private tab'
3. in the new private tab, go to check.torproject.org to make sure Tor
   is enabled
4. right click on the onion image, select 'open image in new tab'
5. in the new tab, go to check.torproect.org to make sure Tor is enabled

auditors: @darkdh
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
0.23.x issue first seen in 0.23.x bug feature/tor QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
6 participants
@diracdeltas @kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya