Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll out HttpsByDefault to 50% of Nightly desktop users #522

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Roll out HttpsByDefault to 50% of Nightly desktop users #522

merged 1 commit into from
Feb 23, 2023

Conversation

arthuredelstein
Copy link
Collaborator

No description provided.

@arthuredelstein arthuredelstein requested a review from a team as a code owner February 13, 2023 19:45
kjozwiak
kjozwiak approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving & Merging so this can checked/verified on staging before uplifting #523.

@kjozwiak kjozwiak merged commit 9a51673 into main Feb 23, 2023
@kjozwiak kjozwiak deleted the issues/521 branch February 23, 2023 05:04
@kjozwiak
Copy link
Member

kjozwiak commented Feb 27, 2023 •
edited
Loading

Desktop verifications on Nightly

Win 11 x64 Test Cases

BraveHttpsByDefaultRolloutStudy:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.62 Chromium: 111.0.5563.33 (Official Build) nightly (64-bit)
-- | --
Revision | 19bd6d0186b7912604e18191826dab9d1df00e2e-refs/branch-heads/5563@{#557}
OS | Windows 11 Version 22H2 (Build 22621.1265)
  • launched 1.50.62 Chromium: 111.0.5563.33 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveHttpsByDefaultRolloutStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that BraveHttpsByDefaultRolloutStudy:Enabled via brave://version
  • ensured that the new HTTPS drop down context menu via the shields panel was added with the following choices
    • Only connect with HTTPS, Upgrade connections to HTTPS (Defualt) and Don't upgrade HTTP connections
  • ensured that the new HTTPS settings are being added via brave://settings/shields with the following choices:
    • Strict, Standard and Disabled
Example Example Example Example Example Example
image image image image image image

BraveHttpsByDefaultRolloutStudy:Enabled - Shields Panel (Upgrade connections to HTTPS)

Using the STR/Cases mentioned via brave/brave-browser#27141 (comment), went through the following:

Example Example Example
image image image

BraveHttpsByDefaultRolloutStudy:Enabled - Shields Panel (Only connect with HTTPS)

Example Example Example Example Example Example Example
image image image image image image image

BraveHttpsByDefaultRolloutStudy:Enabled - Shields Panel (Don't upgrade HTTP connections)

Example Example Example
image image image

BraveHttpsByDefaultRolloutStudy:Enabled - brave://settings/shields (Standard)

Quick QA note: Standard -> Upgrade connections to HTTPS

Using the STR/Cases mentioned via brave/brave-browser#27141 (comment), went through the following:

Basically verified via the Shields Panel (Upgrade connections to HTTPS) section as that's the default case when installing Brave.

BraveHttpsByDefaultRolloutStudy:Enabled - brave://settings/shields (Strict)

Quick QA note: Strict -> Only connect with HTTPS

Example Example Example Example Example Example
image image image image image image

BraveHttpsByDefaultRolloutStudy:Enabled - brave://settings/shields (Strict)

Quick QA note: Disabled -> Don't upgrade HTTP connections

Example Example Example
image image image

BraveHttpsByDefaultRolloutStudy:Enabled - Disable Upgrade connections to HTTPS before join Griffin study

CCing @pes10k @arthuredelstein what's the expected result/behavior's in this case? If a user has previously disabled HTTPS upgrades on a particular website and then gets added into BraveHttpsByDefaultRolloutStudy, should the site-specific setting be set as Upgrade connections to HTTPS or Don't upgrade connections to HTTPS? Currently it's selecting Standard/Upgrade connections to HTTPS which isn't respecting the users previous choice.

Update: Sounds like this is expected as the new feature is different enough from the old feature that it will make it difficult to preserve users previous per-site settings when it comes to HTTPS upgrades.

BraveHttpsByDefaultRolloutStudy:Enabled - Tor Windows

As per brave/brave-browser#27141 (comment), brave://settings are isolated on Tor windows and Strict should always be used.

  • using the STR/Cases mentioned above, ensure that you're part of BraveHttpsByDefaultRolloutStudy:Enabled
  • change Upgrade connections to HTTPS via brave://settings from Standard -> Disabled
  • open a Tor window and wait till it connects to the Tor network and you receive the Tor connected successfully message
  • ensure that http://insecure.arthuredelstein.net displays The connection to insecure.arthuredelstein.net is not secure
    • ensured that Upgrade connections to HTTPS settings are not being displayed via the shields panel
    • ensure that Continue to site loads http://insecure.arthuredelstein.net without any issues
    • ensured that http://insecure.arthuredelstein.net loads without any issues after several restarts once Continue is selected
    • ensured that you Turn on warnings works as expected via the Not Secure drop down
  • ensure that http://http.badssl.com displays The connection to http.badssl.com is not secure
    • ensured that Upgrade connections to HTTPS settings are not being displayed via the shields panel
    • ensure that Continue to site loads http://http.badssl.com without any issues
    • ensured that http://http.badssl.com loads without any issues after several restarts once Continue is selected
    • ensured that you Turn on warnings works as expected via the Not Secure drop down
  • ensured that http://upgradable.arthuredelstein.net -> https://upgradable.arthuredelstein.net (should be upgraded)
    • ensured that Upgrade connections to HTTPS settings are not being displayed via the shields panel
Example Example Example
image image image

BraveHttpsByDefaultRolloutStudy:Defualt (Disabled)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.62 Chromium: 111.0.5563.33 (Official Build) nightly (64-bit)
-- | --
Revision | 19bd6d0186b7912604e18191826dab9d1df00e2e-refs/branch-heads/5563@{#557}
OS | Windows 11 Version 22H2 (Build 22621.1265)
  • launched 1.50.62 Chromium: 111.0.5563.33 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveHttpsByDefaultRolloutStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that BraveHttpsByDefaultRolloutStudy:Default via brave://version
  • ensured that Upgrade connections to HTTPS is still being used via the shields panel
  • ensured that Upgrade connections to HTTPS is NOT being displayed under brave://settings/shields
Example Example Example
image image image

arthuredelstein added a commit that referenced this pull request Feb 28, 2023
@arthuredelstein
Roll out HttpsByDefault to 100% of Nightly desktop users (#522)
c6b511c
This was referenced Feb 28, 2023
Closed
Closed
@kjozwiak kjozwiak mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthuredelstein @kjozwiak