-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify proto JS API for tracker and griffin UI #1253
Conversation
3760af1
to
37cd0d1
Compare
4624ac2
to
6236883
Compare
); | ||
} | ||
case 'platform': { | ||
return value.map((p: string) => platformToString(p)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before this change the logic for revive and replace was in the same file close to each other. Now it's spread a bit. Can we do something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[puLL-Merge] - brave/brave-variations@1253 DescriptionThis PR makes significant changes to the brave-variations project, primarily focusing on updating the protobuf implementation and refactoring the codebase to use a new protobuf-ts library instead of the previously used protobufjs. The changes also include updates to file processing, serialization, and various utility functions. Possible Issues
Security HotspotsNo significant security hotspots were identified in this PR. ChangesChanges
sequenceDiagram
participant Web as Web App
participant Core as Core
participant Proto as Proto Generated
participant Seed as Seed Tools
participant Finch as Finch Tracker
Web->>Core: Use study processor
Core->>Proto: Import new types
Web->>Seed: Use serializers
Seed->>Proto: Import new types
Finch->>Core: Use summary
Finch->>Proto: Use new fromBinary method
Core->>Seed: Use new serializer functions
graph TD
A[Web App] --> B[Core]
A --> C[Seed Tools]
B --> D[Proto Generated]
C --> D
B --> E[Finch Tracker]
E --> D
F[Scripts] --> D
C4 DiagramSequence Diagram |
The PR reimplements finch_tracker and griffin.brave.com using
protobuf-ts
insteadprotobufjs
Also it reuses the serializer from seed_tools that will result in changing the format in finch-data-private